Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GPUifyLoops with KernelAbstractions #95

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Replace GPUifyLoops with KernelAbstractions #95

merged 1 commit into from
Nov 17, 2021

Conversation

thomasfaingnaert
Copy link
Member

@thomasfaingnaert thomasfaingnaert commented Nov 17, 2021 •
edited
Loading

Fixes #86

@codecov
Copy link

codecov bot commented Nov 17, 2021 •
edited
Loading

Codecov Report

Merging #95 (a0a164c) into master (f7ed956) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   41.90%   41.90%           
=======================================
  Files           9        9           
  Lines         420      420           
=======================================
  Hits          176      176           
  Misses        244      244
Impacted Files Coverage Δ
src/epilogue.jl 6.25% <ø> (ø)
src/kernel.jl 100.00% <ø> (ø)
src/layout.jl 16.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ed956...a0a164c. Read the comment docs.

maleadt
maleadt approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was actually thinking of just copying those macros here (to not add another dependency that we don't really need), but I guess this is fine as well.

@thomasfaingnaert thomasfaingnaert merged commit 1c95545 into master Nov 17, 2021
@thomasfaingnaert thomasfaingnaert deleted the tf/replace-gpuifyloops branch November 17, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace GPUifyLoops.@unroll
2 participants
@thomasfaingnaert @maleadt